SQLFetch & SQLGetData Implementation by alinaliBQ · Pull Request #55 · Bit-Quill/arrow

alinaliBQ · 2025-06-27T22:59:41Z

SQLFetch & SQLGetData Implementation + Tests

Remove JSON and struct code Initial draft code SQLExecDirect + Example initial test SQLGetStmtAttr stub implementation Stub call for SQLGetStmtAttr Enable statement handle allocation Implement SQLExecDirect - test hang issue Update odbc_api.cc Run `ShutdownProtobufLibrary` after all ODBC tests Resolves test hanging problem Fix missing break statement in SQLGetDiagRec Add tests Lint fixes Run ShutdownProtobufLibrary as part of test environment Add debug messages Draft code Remove drafts Add comment Add comment for apacheGH-46889 Update statement test headers Pass call options to executed prepared statement `call_options_` contains the authentication token which is needed SQLFetch & SQLGetData initial impl EVERYTHING before this commit is for SQLExecDirect SQLFetch and SQLGetData TestSQLExecDirectSimpleQuery test Make GetData() return SQLRETURN `TestSQLExecDirectDataQuery` for remote and mock servers Remove unneeded test case Add more data types

Add varbinary test

Will leave tests for later

The `TestSQLExecDirectDataQuery` checks for date is not working.

* imported fix from dremio/flightsql-odbc@d44d862, an Apache-Licensed repository

jduo · 2025-07-03T20:02:31Z

+}
+
+void ODBCStatement::getRowCount(SQLLEN* rowCountPtr) {
+  if (!rowCountPtr) {


I don't see in the spec this error mentioned, which means we can actually just return success and not do anything. Same with num result cols.

got it. I have removed the thrown errors for SQLNumResultCols and SQLRowCount

jduo · 2025-07-03T20:02:53Z

+    throw DriverException("Invalid null pointer for number of column results.", "HY000");
+  }
+  size_t columnCount = m_currentArd->GetRecords().size();
+  *columnCountPtr = columnCount;


Need to static_cast<> here.

jduo · 2025-07-03T20:05:41Z

  /// \brief Get invalid connection string for mock server
  std::string getInvalidConnectionString() override;
+  /// \brief Return a SQL query that selects all data types
+  std::wstring getQueryAllDataTypes() override;


We need to repeat these tests but use SQL_C_DEFAULT as the target type instead of the real SQL_C_* type. (Real applications like Excel use SQL_C_DEFAULT).

We should also test SQL_ARD_TYPE when descriptor functions are added such as SQLSetDescField.

We need to validate that the indicator pointer gets set to the correct length (in bytes) for string and binary data. The driver is also allowed to return SQL_NO_TOTAL.

We need to check if a NULL cell correctly sets the indicator pointer to SQL_NULL_DATA.

We should handle test the case where the indicator pointer itself is null.

If the cell is non-NULL this should succeed gracefully.

If the cell is NULL there's an error that should get reported.

Test that when retrieving fixed-length data, if buffer length is set to a garbage value (like a negative number) it gets ignored.

We also need to test retrieving string and binary data in parts. When the buffer length is too small:

Return SQL_SUCCESS_WITH_INFO with error state 01004

I think the indicator pointer is supposed to hold the length of the remaining data after the current chunk. If the indicator pointer is NULL this should behave normally.

Sounds good, today I have added tests for everything you mentioned except case:

Test that when retrieving fixed-length data, if buffer length is set to a garbage value (like a negative number) it gets ignored.

Will continue working on this on Friday

I have added test for passing garbage value as buffer length

- do not return errors for invalid rowCountPtr and columnCountPtr - add static cast for columnCount - Add tests with SQL_C_DEFAULT as target type - Add test checks for indicator - Fix SQL_NUMERIC, SQL_BIT, SQL_FLOAT target type

alinaliBQ

Will continue addressing comments tmr

alinaliBQ · 2025-07-03T20:53:38Z

+}
+
+void ODBCStatement::getRowCount(SQLLEN* rowCountPtr) {
+  if (!rowCountPtr) {


got it. I have removed the thrown errors for SQLNumResultCols and SQLRowCount

alinaliBQ · 2025-07-03T20:55:12Z

+    throw DriverException("Invalid null pointer for number of column results.", "HY000");
+  }
+  size_t columnCount = m_currentArd->GetRecords().size();
+  *columnCountPtr = columnCount;


alinaliBQ · 2025-07-03T22:58:32Z

  /// \brief Get invalid connection string for mock server
  std::string getInvalidConnectionString() override;
+  /// \brief Return a SQL query that selects all data types
+  std::wstring getQueryAllDataTypes() override;


Sounds good, today I have added tests for everything you mentioned except case:

Test that when retrieving fixed-length data, if buffer length is set to a garbage value (like a negative number) it gets ignored.

Will continue working on this on Friday

alinaliBQ · 2025-07-04T18:24:45Z

The C++ / AMD64 Conda C++ AVX2 (pull_request) failures should not due to our code but rather something at Arrow's source

alinaliBQ added 14 commits June 26, 2025 13:40

Add SQL_GUID in getCTypeForSQLType

ac24080

Add data types in query

7480a3f

Add checks for columns 1 to 25

cb196ad

Update statement_test.cc

0675834

Add varbinary test

Implement SQLNumResultCols

ade593d

Will leave tests for later

Implement SQLRowCount

a09ad2b

Implement SQLMoreResults

7edb1e0

Work on date retrieval fix

99f21f8

The `TestSQLExecDirectDataQuery` checks for date is not working.

Fix date retrieval error by importing fix from Paul

a74120e

* imported fix from dremio/flightsql-odbc@d44d862, an Apache-Licensed repository

Add more checks for get data

6e293f7

Add more tests

19492bf

Continue work on float truncation test

cab3b39

Disable float truncation test

26e9a4d

alinaliBQ closed this Jul 3, 2025

alinaliBQ reopened this Jul 3, 2025

jduo reviewed Jul 3, 2025

View reviewed changes

Address comments from James

e38f567

- do not return errors for invalid rowCountPtr and columnCountPtr - add static cast for columnCount - Add tests with SQL_C_DEFAULT as target type - Add test checks for indicator - Fix SQL_NUMERIC, SQL_BIT, SQL_FLOAT target type

alinaliBQ commented Jul 4, 2025

View reviewed changes

rscales approved these changes Jul 4, 2025

View reviewed changes

alinaliBQ added 3 commits July 4, 2025 09:58

Fix build issues in CI

d5998db

More fix for CI

efc3eca

Add test for invalid buffer length

27364fa

alinaliBQ mentioned this pull request Jul 4, 2025

SQLPrepare & SQLExecute Implementation #58

Merged

alinaliBQ marked this pull request as ready for review July 4, 2025 19:04

jduo approved these changes Jul 4, 2025

View reviewed changes

alinaliBQ merged commit 9109e6f into apache-odbc Jul 4, 2025
22 of 24 checks passed

alinaliBQ deleted the sqlfetch-sqlgetdata branch July 4, 2025 21:08

Uh oh!

Conversation

alinaliBQ commented Jun 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants